Conversation
This is necessary for us to test features like covariant returns because we need to be able to target `net5.0` in our unit test projects. Issues encountered in this update: - WinRT is no longer supported in .NET 5. As a result we no longer multi-target .NET Core in our WinRT test assembly as well as having to disabling a few WinRT tests in others. dotnet/runtime#37672 - Change our Debugger Proxy tests to react to a runtime change dotnet/runtime@c362923 - Work around .NET5 P6 bug dotnet/sdk#11862
|
@dotnet/roslyn-infrastructure PTAL |
docs/contributing/Building, Debugging, and Testing on Windows.md
Outdated
Show resolved
Hide resolved
sharwell
left a comment
There was a problem hiding this comment.
There seems to be some inconsistency between references to Preview 6 and Preview 7. I suggested changes to consolidate on Preview 7.
Turns out it hit release just as I was re-prepping this change for review. All my work had been done off of preview 6. |
|
@sharwell should be consistent now. |
|
Does this need to wait until 16.8-preview1 is publicly released before merging? |
|
@RikkiGibson no. The P8 build is the one that has a 16.8 requirement, not P7. |
|
The one test failure is |
|
LGTM |
This is necessary for us to test features like covariant returns because
we need to be able to target
net5.0in our unit test projects.Issues encountered in this update:
.NET Core in our WinRT test assembly as well as having to disabling a
few WinRT tests in others. [Breaking change] Removal of built-in WinRT support in .NET 5.0 runtime#37672
dotnet/runtime@c362923