Merged
Conversation
The compiler logging support primarily helped with identifying issues with the underlying protocol. That was an area of problem in the initial compiler server development and a sensible logging scenario. Now though the underlying protocol isn't really an issue for the server. The bigger issue is tracking the underlying state transitions of the server and the reasons for making such transitions. This PR moves our logging to match this new reality.
Member
Author
|
@dotnet/roslyn-compiler PTAL |
jaredpar
commented
Jul 15, 2020
|
|
||
| public override ResponseType Type => ResponseType.Rejected; | ||
|
|
||
| public RejectedBuildResponse(string reason) |
Member
Author
There was a problem hiding this comment.
This is the most impactful part of the change because it forces us to declare a reason every time we reject a build. Note that rejecting a build is different than a build failing. A build failing is a completed build (it just failed). A rejected build is one the server said "i can't handle this, fall back to csc / vbc".
chsienki
reviewed
Jul 15, 2020
chsienki
reviewed
Jul 15, 2020
chsienki
approved these changes
Jul 15, 2020
333fred
reviewed
Jul 15, 2020
| for (int i = 0; i < args.Count; ++i) | ||
| { | ||
| var arg = args[i]; | ||
| Log($"argument[{i}] = {arg}"); |
Member
Author
There was a problem hiding this comment.
Logging these arguments ends up taking up 95% of the log file. It basically makes the file unreadable without massive filtering. The arguments are all present in the binlog so it doesn't really add anything here.
Member
Author
|
Integration test are a known issue. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiler logging support primarily helped with identifying issues
with the underlying protocol. That was an area of problem in the initial
compiler server development and a sensible logging scenario.
Now though the underlying protocol isn't really an issue for the server.
The bigger issue is tracking the underlying state transitions of the
server and the reasons for making such transitions. This PR moves our
logging to match this new reality.