Fix PropertiesInRecursivePattern_PositionalInFirstProperty_AfterComma#45990
Merged
Fix PropertiesInRecursivePattern_PositionalInFirstProperty_AfterComma#45990
Conversation
genlu
approved these changes
Jul 15, 2020
Member
Author
|
@gafter We are seeing this test fail and are setting it back to be skipped. |
Member
You can fix this test instead of skipping it by replacing this line with await VerifyNoItemsExistAsync(markup);Refers to: src/EditorFeatures/CSharpTest/Completion/CompletionProviders/PropertySubPatternCompletionProviderTests.cs:506 in be94205. [](commit_id = be94205, deletion_comment = False) |
Member
|
/cc @CyrusNajmabadi |
Member
Author
|
Thanks @gafter. A fix works even better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds skip back toPropertiesInRecursivePattern_PositionalInFirstProperty_AfterCommawhich was unskipped in https://github.com/dotnet/roslyn/pull/45771/filesFixes the test based on Gafter's comment.
Also see #40015 for other skipped pattern tests