Add module initializers tests#45969
Merged
RikkiGibson merged 1 commit intodotnet:features/module-initializersfrom Jul 15, 2020
Merged
Add module initializers tests#45969RikkiGibson merged 1 commit intodotnet:features/module-initializersfrom
RikkiGibson merged 1 commit intodotnet:features/module-initializersfrom
Conversation
Member
Author
|
@dotnet/roslyn-compiler Could I please get a review of this test-only change? |
jaredpar
approved these changes
Jul 15, 2020
AlekseyTs
reviewed
Jul 15, 2020
|
|
||
| [ModuleInitializer] // 4 | ||
| static partial void M4(); | ||
| [ModuleInitializer] // 5 |
Contributor
There was a problem hiding this comment.
[ModuleInitializer] // 5 [](start = 4, length = 24)
Do we have a test for a scenario when the second application is allowed?
AlekseyTs
reviewed
Jul 15, 2020
| { | ||
| [ModuleInitializer] | ||
| public static partial void M1(); | ||
| [ModuleInitializer] // 1 |
Contributor
There was a problem hiding this comment.
[ModuleInitializer] // 1 [](start = 4, length = 24)
Do we have a test for a scenario when the second application is allowed?
AlekseyTs
approved these changes
Jul 15, 2020
Contributor
AlekseyTs
left a comment
There was a problem hiding this comment.
LGTM (iteration 1), with suggested tests, which can be added in a separate PR
Member
Author
|
Thanks, will open a new PR to add the additional tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filling out test plan #40500