Skip to content

Disable interpreting of strings as DateTime during deserialization#45891

Merged
tmat merged 1 commit intodotnet:release/dev16.7from
tmat:JsonDateTime
Jul 15, 2020
Merged

Disable interpreting of strings as DateTime during deserialization#45891
tmat merged 1 commit intodotnet:release/dev16.7from
tmat:JsonDateTime

Conversation

@tmat
Copy link
Member

@tmat tmat commented Jul 10, 2020 •
edited
Loading

Fixes #39429.

@tmat tmat requested a review from a team as a code owner July 10, 2020 21:34
@tmat
Copy link
Member Author

tmat commented Jul 10, 2020

@vatsalyaagrawal For 16.7 approval

@tmat tmat changed the base branch from master to release/dev16.7 July 10, 2020 21:37
@jasonmalinowski
Copy link
Member

jasonmalinowski commented Jul 11, 2020

Wait, so if the change looks like a date, then we'd be sending that as the string of the diff and that'd break things? Is there any other settings we should be changing here too?

@tmat
Copy link
Member Author

tmat commented Jul 11, 2020

@jasonmalinowski Correct. @AArnott is not aware of any other switches.

@tmat tmat merged commit 7a7466a into dotnet:release/dev16.7 Jul 15, 2020
@tmat tmat deleted the JsonDateTime branch July 15, 2020 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

@dibarbet dibarbet dibarbet approved these changes

+1 more reviewer

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Approved to merge Area-IDE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

When pasting json into a comment in C# code, an error is shown

5 participants

@tmat @jasonmalinowski @CyrusNajmabadi @dibarbet @jinujoseph