Merged
Conversation
tmat
commented
Jul 10, 2020
Member
Author
There was a problem hiding this comment.
Another pending PR is moving this file and changing namespace Microsoft.CodeAnalysis.Test.Utilities.RemoteHost to Microsoft.CodeAnalysis.Remote.Testing, so for now leave it like so to avoid merge issues.
Member
Author
|
@CyrusNajmabadi @dotnet/roslyn-ide PTAL |
mavasani
reviewed
Jul 10, 2020
src/EditorFeatures/Test2/ReferenceHighlighting/AbstractReferenceHighlightingTests.vb
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Jul 10, 2020
src/EditorFeatures/Test2/ReferenceHighlighting/AbstractReferenceHighlightingTests.vb
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Jul 10, 2020
mavasani
approved these changes
Jul 10, 2020
Contributor
mavasani
left a comment
There was a problem hiding this comment.
Overall LGTM. Probably want to confirm with Cyrus about OutOfProcess_SplitCall/SingleCall values.
ryzngard
approved these changes
Jul 10, 2020
Contributor
|
Everything looks fine except for the rename case. either fix or revert that bit. i'm happy to fixup the rename side later if you don't want to deal with it now :) |
Member
Author
|
@CyrusNajmabadi Fixed. |
sharwell
reviewed
Jul 16, 2020
|
|
||
| public static Option<bool> OOP64Bit => new Option<bool>( | ||
| nameof(RemoteHostOptions), nameof(OOP64Bit), defaultValue: false, | ||
| storageLocations: new LocalUserProfileStorageLocation(LocalRegistryPath + nameof(OOP64Bit))); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tests used
bool outOfProcessand othersTestHostenum (multiple copies of it).Replace
bool outOfProcesswith a singleTestHostenum everywhere.