[Dogfooding] Extend existing IDE code style enforcement rules to EditorFeatures layer#45847
Merged
18 commits merged intodotnet:masterfrom Jul 11, 2020
Merged
[Dogfooding] Extend existing IDE code style enforcement rules to EditorFeatures layer#4584718 commits merged intodotnet:masterfrom
18 commits merged intodotnet:masterfrom
Conversation
Builds on top of prior PRs that aim at dogfooding code style enforcement in IDE layers.
…rivate members) violations
sharwell
reviewed
Jul 9, 2020
src/EditorFeatures/Core/Implementation/TextBufferAssociatedViewService.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/Core/Implementation/CodeFixes/CodeFixService.cs
Outdated
Show resolved
Hide resolved
...EditorFeatures/Core/Implementation/Diagnostics/AbstractDiagnosticsAdornmentTaggerProvider.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Jul 10, 2020
Contributor
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
a few things to look at. but overall this is great to me.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strongly recommended to review commit-by-commit
Builds on top of prior PRs that aim at dogfooding code style enforcement in IDE layers. No new rules are enforced here, just existing rules are now respected in
EditorFeatureslayer.