Merged
Conversation
This annotation revealed a number of places where if some part of RQName generation failed, we'd end up creating RQNode objects with null fields; trying to convert that to the text would end up crashing. This adds proper error handling when issues were discovered by analysis.
Nothing is using UnresolvedRQNode directly, so we can just flatten the type hierarchy a bit.
davidwengier
approved these changes
Jul 9, 2020
Member
davidwengier
left a comment
There was a problem hiding this comment.
I have no context, but the annotations make sense to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some cleanup of our RQName generation code.
This partially fixes/addresses #45805 by ensuring we aren't going to be triggering asserts. I'm not going to close that bug quite yet as I'm not sure if we're going to need to update RQNames to support a RQName format for function pointers, but this should make it fairly less broken.
Commit-at-a-time will make it a bit clearer what each step was, but it's straightforward all at once.