Merged
Conversation
tmat
commented
Jul 8, 2020
tmat
commented
Jul 8, 2020
src/Workspaces/CoreTestUtilities/SnapshotSerializationTestBase.cs
Outdated
Show resolved
Hide resolved
23f4078 to
a9cc2aa
Compare
Member
Author
|
@CyrusNajmabadi @dotnet/roslyn-ide PTAL |
Contributor
|
Can you add a short description of the goal of this refactoring? |
Member
Author
|
Sure. |
ryzngard
approved these changes
Jul 10, 2020
CyrusNajmabadi
approved these changes
Jul 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up RemotableDataService - removing test-only code and renaming the file to match the class name.
Encapsulates services needed for serialization validation in
SerializationValidatorclass.