Skip to content

Make netcoreapp3.1 the preferred target framework#45794

Merged
sharwell merged 1 commit intodotnet:masterfrom
sharwell:prefer-netcoreapp
Jul 8, 2020
Merged

Make netcoreapp3.1 the preferred target framework#45794
sharwell merged 1 commit intodotnet:masterfrom
sharwell:prefer-netcoreapp

Conversation

@sharwell
Copy link
Contributor

@sharwell sharwell commented Jul 8, 2020

This change ensures that Roslyn.sln files open by default in an editor that supports nullable reference types (with framework annotations).

@sharwell sharwell requested review from a team as code owners July 8, 2020 19:02
Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also beneficial when working from VS Code as OmniSharp only loads the project under the first TFM listed and this will match the Compiler's ordering.

Copy link
Member

@genlu genlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know the order actually matters

@sharwell sharwell merged commit f4a1467 into dotnet:master Jul 8, 2020
@ghost ghost added this to the Next milestone Jul 8, 2020
@sharwell sharwell deleted the prefer-netcoreapp branch July 8, 2020 23:50
@JoeRobich JoeRobich modified the milestones: Next, 16.8.P1 Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants