Update Roslyn.Services.UnitTests.Utilities to target netcoreapp3.1#45793
Merged
sharwell merged 1 commit intodotnet:masterfrom Jul 9, 2020
Merged
Update Roslyn.Services.UnitTests.Utilities to target netcoreapp3.1#45793sharwell merged 1 commit intodotnet:masterfrom
sharwell merged 1 commit intodotnet:masterfrom
Conversation
sharwell
commented
Jul 8, 2020
28cd4fa to
4a66393
Compare
genlu
reviewed
Jul 8, 2020
|
|
||
| #if !NETCOREAPP | ||
| using System; | ||
| using Roslyn.Utilities; |
Contributor
Author
There was a problem hiding this comment.
The using directives are only used in one framework.
Member
There was a problem hiding this comment.
Minor curiousity: what about Roslyn.Utilities gets used in .NET Core here? There aren't any particular code changes in the PR that hook into new APIs.
Contributor
Author
There was a problem hiding this comment.
@jaredpar None of them do, hence the exclusion for that build 😄
Member
There was a problem hiding this comment.
🤦
This is what I get for commenting before finishing my coffee
jaredpar
approved these changes
Jul 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.