Skip to content

Do not drop a comma when parsing a tuple pattern#45771

Merged
gafter merged 1 commit intodotnet:masterfrom
gafter:master-45757
Jul 9, 2020
Merged

Do not drop a comma when parsing a tuple pattern#45771
gafter merged 1 commit intodotnet:masterfrom
gafter:master-45757

Conversation

@gafter
Copy link
Member

@gafter gafter commented Jul 7, 2020

Fixes #45757

@gafter gafter requested review from a team as code owners July 7, 2020 23:36
@gafter gafter requested a review from CyrusNajmabadi July 7, 2020 23:37
@gafter gafter self-assigned this Jul 7, 2020
@gafter gafter added this to the 16.8 milestone Jul 7, 2020
@gafter
Copy link
Member Author

gafter commented Jul 7, 2020

/cc @CyrusNajmabadi

@gafter
Copy link
Member Author

gafter commented Jul 9, 2020

@dotnet/roslyn-compiler May I please have a second (senior) review for this small bug fix?

@cston
Copy link
Contributor

cston commented Jul 9, 2020

                        var parenthesizedPattern = _syntaxFactory.ParenthesizedPattern(openParenToken, subPatterns[0].Pattern, closeParenToken);

subpattern


Refers to: src/Compilers/CSharp/Portable/Parser/LanguageParser_Patterns.cs:325 in 7d8fa34. [](commit_id = 7d8fa34, deletion_comment = False)

@gafter gafter merged commit 0bc9969 into dotnet:master Jul 9, 2020
@ghost ghost modified the milestones: 16.8, Next Jul 9, 2020
@JoeRobich JoeRobich modified the milestones: Next, 16.8.P1 Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parsing bug in recursive patterns

5 participants