Update TestImpact public key in additional IVTs#45763
Update TestImpact public key in additional IVTs#45763sharwell merged 3 commits intodotnet:masterfrom
Conversation
|
|
| <InternalsVisibleTo Include="Microsoft.CodeAnalysis.Remote.ServiceHub" /> | ||
| <InternalsVisibleTo Include="Microsoft.CodeAnalysis.Remote.Workspaces" /> | ||
| <RestrictedInternalsVisibleTo Include="Microsoft.CodeAnalysis.LiveUnitTesting.Orchestrator" Partner="UnitTesting" /> | ||
| <RestrictedInternalsVisibleTo Include="Microsoft.CodeAnalysis.LiveUnitTesting.Orchestrator" Partner="UnitTesting" Key="$(UnitTestingKey)" /> |
There was a problem hiding this comment.
tag @mavasani
So Vritant is doing a repo move (testimpact to VS Unit Testing). So it affects the public keys used.
Is there anyway to temporarily keep the old IVT and at the same time adding a new one with a different key? (Because we don't want to break the lastest master)
Or maybe we need to sync with the roslyn insertion?
There was a problem hiding this comment.
The cleanest way to keep things from breaking is preserving the key during the source code move (i.e. no Roslyn change required). If the key does change, it might be possible to have duplicate lines here (one with each key), but if that doesn't work it will need to be a coordinated insertion.
There was a problem hiding this comment.
It wouldn't be ideal to preserve the existing key, and having duplicate lines here does not work in my testing. Whether it's two RestrictedInternalsVisibleTo or an additional InternalsVisibleTo. So it looks like it will have to be a coordinated insertion if there isn't another way.
What would be the process of doing so?
There was a problem hiding this comment.
I was incorrect in my testing. Older packages were being pulled in from my .nuget cache and producing unexpected results since the built dev package versions didn't change.
Having duplicate roslyn versions do work, and so this can be phased in. So, pushing this change in shouldn't break the current testimpact, and should also work with the new binaries with different public keys.
There was a problem hiding this comment.
Do we have a work item tracking removal of these duplicate entries?
There was a problem hiding this comment.
I have created one here https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1155201
|
@mavasani would there be a way to expose the IVTs to both the old assemblies and the new assemblies with different public keys and the same name? |
This reverts commit ca662f2.
The TestImpact repository is moving from GitHub into AzDo within the Vs Unit Testing repo, and thus the public key of the assemblies will change.
The restricted IVTs are changed to work with the new public key