Skip to content

Remove requirement to list all transitively referenced projects in Pr…#45731

Merged
tmat merged 2 commits intodotnet:masterfrom
tmat:RemoveProjectRefCheck
Jul 7, 2020
Merged

Remove requirement to list all transitively referenced projects in Pr…#45731
tmat merged 2 commits intodotnet:masterfrom
tmat:RemoveProjectRefCheck

Conversation

@tmat
Copy link
Member

@tmat tmat commented Jul 7, 2020

…ojectReferences of each project

We believe this check is no longer necessary. It used to be an issue when using legacy projects.

@tmat tmat requested a review from a team as a code owner July 7, 2020 02:07
@tmat
Copy link
Member Author

tmat commented Jul 7, 2020

@jaredpar

@jaredpar
Copy link
Member

jaredpar commented Jul 7, 2020

This is a great lesson in the idea that when you find a bug in a product you need to:

  1. File that bug
  2. Reference that bug in the commit you use to work around the bug.

😦

At this point I agree this is probably not an issue anymore and we have other checks for this case in our infra. Can revisit if we find that it still exists.

@tmat tmat merged commit d59a2b3 into dotnet:master Jul 7, 2020
@ghost ghost added this to the Next milestone Jul 7, 2020
@tmat tmat deleted the RemoveProjectRefCheck branch July 7, 2020 17:23
@JoeRobich JoeRobich modified the milestones: Next, 16.8.P1 Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants