Skip to content

Consider nullability in ReferenceIndexerBase#45714

Merged
cston merged 1 commit intodotnet:masterfrom
cston:44348
Jul 7, 2020
Merged

Consider nullability in ReferenceIndexerBase#45714
cston merged 1 commit intodotnet:masterfrom
cston:44348

Conversation

@cston
Copy link
Contributor

@cston cston commented Jul 6, 2020

Fixes #44348

@cston cston marked this pull request as ready for review July 7, 2020 01:33
@cston cston requested a review from a team as a code owner July 7, 2020 01:33
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@jcouv jcouv self-assigned this Jul 7, 2020
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (iteration 2)

@cston cston merged commit 0597445 into dotnet:master Jul 7, 2020
@ghost ghost added this to the Next milestone Jul 7, 2020
@cston cston deleted the 44348 branch July 7, 2020 19:21
@AlekseyTs
Copy link
Contributor

As we discussed offline, please open an issue for us to come back and try to address the whole family of issues like that, perhaps by making adjustments to the symbol translation layer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Debug bootstrap build fails when annotations are added to LocalDataFlowPass

5 participants