Expose BoundPattern.ConvertedType in IPatternOperation#45712
Merged
333fred merged 6 commits intodotnet:masterfrom Jul 8, 2020
Merged
Expose BoundPattern.ConvertedType in IPatternOperation#45712333fred merged 6 commits intodotnet:masterfrom
333fred merged 6 commits intodotnet:masterfrom
Conversation
Member
|
/cc @333fred @AlekseyTs |
333fred
reviewed
Jul 7, 2020
Member
|
It might be a good idea to name it |
gafter
suggested changes
Jul 7, 2020
Member
gafter
left a comment
There was a problem hiding this comment.
Please rename it NarrowedType instead of ConvertedType or OutputType to match the specification.
Member
Author
|
Test failures don't seem to be related. |
333fred
approved these changes
Jul 8, 2020
Member
333fred
left a comment
There was a problem hiding this comment.
LGTM (commit 6). I've requeued the failed jobs as they look unrelated to me as well.
Member
|
Thanks @alrz! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45681