Implement SyntaxFacts.IsInTypeOnlyContext for type of recursive pattern.#45699
Merged
gafter merged 2 commits intodotnet:masterfrom Jul 9, 2020
Merged
Implement SyntaxFacts.IsInTypeOnlyContext for type of recursive pattern.#45699gafter merged 2 commits intodotnet:masterfrom
gafter merged 2 commits intodotnet:masterfrom
Conversation
CyrusNajmabadi
approved these changes
Jul 6, 2020
jcouv
approved these changes
Jul 6, 2020
Member
jcouv
left a comment
There was a problem hiding this comment.
LGTM Thanks (iteration 1).
Consider adding a compiler-level test (but I know that we already lack those for IsInTypeOnlyContext API).
Member
Author
|
@CyrusNajmabadi I have added a test from the contributor in iteration 2. Could you please review it? |
Member
Author
|
@dotnet/roslyn-compiler May I please have a second review? |
RikkiGibson
approved these changes
Jul 7, 2020
kevinsun-dev
approved these changes
Jul 7, 2020
Contributor
|
still lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45661