[Feature] Constant Interpolated Strings- Versioning Check & Test Suite#45685
Conversation
This is going to break so many things...
…ub.com/dotnet/roslyn into features/interpolated-string-constants
|
Done review pass (commit 7) #Closed |
|
Done review pass (commit 8) #Closed |
|
Done review pass (commit 9). Just a couple more tests. #Closed |
|
Done review pass (commit 11) #Closed |
|
Done review pass (commit 12). One more small rename and I think this should be good. |
333fred
left a comment
There was a problem hiding this comment.
LGTM (commit 15). @dotnet/roslyn-compiler for a second review.
|
Test failures appear legitimate. |
Compilers.sln
Outdated
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "CSharpSyntaxGenerator", "src\Tools\Source\CompilerGeneratorTools\Source\CSharpSyntaxGenerator\CSharpSyntaxGenerator.csproj", "{288089C5-8721-458E-BE3E-78990DAB5E2D}" | ||
| EndProject | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "IOperationGenerator", "src\Tools\Source\CompilerGeneratorTools\Source\IOperationGenerator\CompilersIOperationGenerator.csproj", "{D0A79850-B32A-45E5-9FD5-D43CB345867A}" | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "CompilersIOperationGenerator", "src\Tools\Source\CompilerGeneratorTools\Source\IOperationGenerator\CompilersIOperationGenerator.csproj", "{D0A79850-B32A-45E5-9FD5-D43CB345867A}" |
There was a problem hiding this comment.
I don't quite know how that got in there, I thought I explicitly left it out, like I had for the past several commits. Does it make enough of a difference to remove it?
There was a problem hiding this comment.
Huh, git checkout can revert just a single file. That's a really convenient trick.
|
@dotnet/roslyn-compiler for a second review. |
| } | ||
| }"; | ||
| var comp = CreateCompilation(source, parseOptions: TestOptions.RegularPreview); | ||
| comp.VerifyDiagnostics(); |
There was a problem hiding this comment.
VerifyDiagnostics [](start = 17, length = 17)
Can you also please verify diagnostics for a C# 8 compilation? Never mind, tested elsewhere. #Resolved
[Feature] Constant Interpolated Strings
New in this PR: