Fix "Tuple to Struct" named parameters being cased incorrectly#45667
Merged
9 commits merged intodotnet:masterfrom Jul 6, 2020
Merged
Fix "Tuple to Struct" named parameters being cased incorrectly#456679 commits merged intodotnet:masterfrom
9 commits merged intodotnet:masterfrom
Conversation
…ncorrect test output
...es/CSharp/Portable/ConvertTupleToStruct/CSharpConvertTupleToStructCodeRefactoringProvider.cs
Outdated
Show resolved
Hide resolved
...es/CSharp/Portable/ConvertTupleToStruct/CSharpConvertTupleToStructCodeRefactoringProvider.cs
Show resolved
Hide resolved
...es/Core/Portable/ConvertTupleToStruct/AbstractConvertTupleToStructCodeRefactoringProvider.cs
Outdated
Show resolved
Hide resolved
...es/Core/Portable/ConvertTupleToStruct/AbstractConvertTupleToStructCodeRefactoringProvider.cs
Outdated
Show resolved
Hide resolved
...asic/Portable/ConvertTupleToStruct/VisualBasicConvertTupleToStructCodeRefactoringProvider.vb
Show resolved
Hide resolved
...es/Core/Portable/ConvertTupleToStruct/AbstractConvertTupleToStructCodeRefactoringProvider.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Jul 6, 2020
Contributor
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
Everything is a nit. So in this case the next step is up to you. If you are fine with the code and don't feel it needs changing, feel free to merge. Or, make any changes you feel are appropriate based on the review. A s long as you don't change anything deeply substantive (i.e. radically changing the approach here), you don't really need another review unless you want it :)
Member
Author
|
Thanks for the review |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45451
When converting a tuple to a struct the casing was changed for the parameters of the generated constructor but the call sites weren't changed resulting in a compile error.
Reviewing commit-by-commit might be best, as there were a few analyzer warnings to clean up, but not enough that I thought it was worth a separate PR.