Report use-site diagnostics in BindWithExpression#45664
Merged
AlekseyTs merged 1 commit intodotnet:masterfrom Jul 7, 2020
Merged
Report use-site diagnostics in BindWithExpression#45664AlekseyTs merged 1 commit intodotnet:masterfrom
AlekseyTs merged 1 commit intodotnet:masterfrom
Conversation
Contributor
Author
|
@cston, @jcouv , @RikkiGibson, @dotnet/roslyn-compiler Please review |
cston
reviewed
Jul 6, 2020
| diagnostics.Add(ErrorCode.ERR_NoSingleCloneMethod, syntax.Expression.Location, receiverType); | ||
| } | ||
|
|
||
| diagnostics.Add(syntax.Expression, useSiteDiagnostics); |
Contributor
There was a problem hiding this comment.
Please add a test that is affected by the change. #Resolved
Contributor
Author
There was a problem hiding this comment.
Please add a test that is affected by the change.
I do not believe it is worth spending time looking for the scenario. Code like this should be written mechanically without waiting for something to break. This is the same as passing DiagnosticsBag around.
In reply to: 450415003 [](ancestors = 450415003)
Contributor
Author
|
@cston, @jcouv , @RikkiGibson, @dotnet/roslyn-compiler Please review |
cston
approved these changes
Jul 7, 2020
RikkiGibson
approved these changes
Jul 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.