Conversation
… generators on Linux doesn't produce newline differences.
|
@dotnet/roslyn-compiler for a review of this small change. |
| tokenText = tokenText.Replace("""", """""") | ||
| End If | ||
|
|
||
| If tokenText IsNot Nothing AndAlso tokenText.Contains(vbCrLf) Then |
There was a problem hiding this comment.
LineContinuationTrivia encodes a CRLF into it's TokenText. We replace this with whatever the environment newline is.
|
Should there be some assertion that the generated code does not introduce CR characters if it is not running on Windows? |
In principle, yes. However, unless we actually run the generators on a Linux/Mac run, realistically you or I are going to be the ones that hit it later down the line, and it's already visible as git diff changes when those files aren't touched. |
...ource/CompilerGeneratorTools/Source/VisualBasicSyntaxGenerator/RedNodes/SyntaxFactsWriter.vb
Show resolved
Hide resolved
|
@RikkiGibson any further comments? |
Got it, I guess we only run the generators in the correctness run currently? |
Yep. |
Generate VB code in a platform-agnostic manner that does not introduce cr's on non-windows platforms.