Skip to content

Fix VB case correction for named tuple identifiers#45614

Merged
CyrusNajmabadi merged 8 commits intodotnet:masterfrom
hartmair:master
Jul 11, 2020
Merged

Fix VB case correction for named tuple identifiers#45614
CyrusNajmabadi merged 8 commits intodotnet:masterfrom
hartmair:master

Conversation

@hartmair
Copy link
Contributor

@hartmair hartmair commented Jul 2, 2020

Do not auto-case named tuple name identifiers, fixes #45508

Markus Hartmair added 2 commits July 2, 2020 18:50
Add test infrastructure for case correction and a failing test case for #45508
Do not auto-case named tuple name identifiers, fixes #45508
@hartmair hartmair requested a review from a team as a code owner July 2, 2020 16:54
@dnfadmin
Copy link

dnfadmin commented Jul 2, 2020

CLA assistant check
All CLA requirements met.

Markus Hartmair added 2 commits July 2, 2020 20:14
@hartmair hartmair requested a review from CyrusNajmabadi July 3, 2020 11:07
@jinujoseph jinujoseph added Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Jul 6, 2020
hartmair added 3 commits July 7, 2020 07:59
Forward integration from dotnet/roslyn
Forward integration from dotnet/roslyn
Forward integration from dotnet/roslyn
@hartmair
Copy link
Contributor Author

hartmair commented Jul 11, 2020

I had a hard time getting the build pipeline green, mostly because of network related issues :/
@CyrusNajmabadi Ready for next review iteration or merge into master.

Copy link
Contributor

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr!

@CyrusNajmabadi CyrusNajmabadi merged commit 21803cb into dotnet:master Jul 11, 2020
@ghost ghost added this to the Next milestone Jul 11, 2020
@JoeRobich JoeRobich modified the milestones: Next, 16.8.P1 Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not auto-case VB tuple names

5 participants