Skip to content

Build Roslyn.sln using dotnet#45589

Merged
tmat merged 1 commit intodotnet:masterfrom
tmat:BuildCore
Jul 6, 2020
Merged

Build Roslyn.sln using dotnet#45589
tmat merged 1 commit intodotnet:masterfrom
tmat:BuildCore

Conversation

@tmat
Copy link
Member

@tmat tmat commented Jul 1, 2020

Roslyn.sln can now be built using dotnet build/pack. VSIXes are not produced from such build.

Allows us to run test projects targeting .NET Core that are not in Compilers.sln.

@tmat tmat marked this pull request as ready for review July 2, 2020 17:59
@tmat tmat requested review from a team as code owners July 2, 2020 17:59
@tmat
Copy link
Member Author

tmat commented Jul 2, 2020

@jaredpar @dotnet/roslyn-infrastructure PTAL

@tmat
Copy link
Member Author

tmat commented Jul 2, 2020

@jasonmalinowski

@jmarolf
Copy link
Contributor

jmarolf commented Jul 6, 2020

VSIXes are not produced from such build.

I assume this is because we need .NET Core compatible versions of those targets?

@tmat
Copy link
Member Author

tmat commented Jul 6, 2020

@jaredpar
Copy link
Member

jaredpar commented Jul 6, 2020

Really excited about this. Would much prefer to just dotnet build all the time vs having to hunt down the proper msbuild.

VSIXes are not produced from such build.

What is the mechanism that makes this happen? I can see from the change why we don't produce the uber VSIX anymore but can't see why the individual VSIX are no longer building.

@tmat
Copy link
Member Author

tmat commented Jul 6, 2020

Arcade skips VSIX targets when building on .NET Core.

@tmat tmat merged commit 295a420 into dotnet:master Jul 6, 2020
@ghost ghost added this to the Next milestone Jul 6, 2020
@tmat tmat deleted the BuildCore branch July 6, 2020 22:07
@JoeRobich JoeRobich modified the milestones: Next, 16.8.P1 Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants