Reserve feature branch error codes#45567
Conversation
| ERR_8815 = 8815, | ||
|
|
||
| [Obsolete("used by features/module-initializers")] | ||
| ERR_8816 = 8816, |
There was a problem hiding this comment.
Do we need [Obsolete] attributes? Would the comment plus placeholders be sufficient?
// Codes 8813, ... used by features/module-initializers
ERR_8813 = 8813,
...
333fred
left a comment
There was a problem hiding this comment.
@RikkiGibson, won't this cause merge pain for these branches? Every time they make a change in this file, merging master in could be just as annoying as it is today.
|
The pain without this "reserving" approach is having to find new error codes if yours get taken, the pain after this approach is basically taking the feature branch version of the affected lines and fixing compile errors by deleting references in DiagnosticTest.cs. To be honest I normally wouldn't bother with a change like this, it's just that 1. I'd like to keep the error codes for a feature together, 2. the codes for these branches pack really well in these spots, and 3. the feature branches will merge fairly soon. |
|
LGTM. I wonder if we can come up with some mechanism of reserving across branches in the future. Something as simple as a shared excel sheet on a sharepoint that lets us track the various ones across branches. This seems to be a common pain point in feature branch merges... |
#44911 ended up using error codes which are in use in a feature branch. Since it's tricky to pack these error codes together I'd like to just move the LangVersion 9 error code over to a single unoccupied space in the C# 9 range, if that's acceptable. Also using a more obvious method to indicate that the error codes are in use in feature branches. Hopefully this will all be moot in a few weeks after we've finished feature review and ensured test coverage, etc. on par with our standards.