Skip to content

Reduce release/x64 baseline in DeeplyNestedGeneric#45554

Merged
333fred merged 1 commit intomasterfrom
dev/rigibson/deeplynestedgeneric
Jun 30, 2020
Merged

Reduce release/x64 baseline in DeeplyNestedGeneric#45554
333fred merged 1 commit intomasterfrom
dev/rigibson/deeplynestedgeneric

Conversation

@RikkiGibson
Copy link
Member

/cc @dibarbet. This test seems to be unreliable currently.

@RikkiGibson RikkiGibson added Area-Compilers Test Test failures in roslyn-CI labels Jun 30, 2020
@RikkiGibson RikkiGibson requested a review from a team as a code owner June 30, 2020 02:35
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost
Copy link

ghost commented Jun 30, 2020

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. DotNet Maestro - Int
  2. DotNet Maestro

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@jaredpar
Copy link
Member

Can we port this change to the 16.7 release branch? Think this got merged after we snapped.

@JoeRobich JoeRobich deleted the dev/rigibson/deeplynestedgeneric branch June 30, 2020 18:28
@JoeRobich JoeRobich modified the milestones: Next, 16.8.P1 Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers auto-merge Test Test failures in roslyn-CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants