Demonstrate behavior of GetTypeInfo on 'var' in lambda#45541
Merged
RikkiGibson merged 2 commits intodotnet:masterfrom Jun 30, 2020
Merged
Demonstrate behavior of GetTypeInfo on 'var' in lambda#45541RikkiGibson merged 2 commits intodotnet:masterfrom
RikkiGibson merged 2 commits intodotnet:masterfrom
Conversation
333fred
previously approved these changes
Jun 30, 2020
Member
333fred
left a comment
There was a problem hiding this comment.
Yeah, this is to do with one of the places that we do error recovery, but don't then call the walker rewrite. I'm not sure it's a priority issue, but it would be good to fix at some point.
333fred
reviewed
Jun 30, 2020
| private static string s_data; | ||
| static void Main() | ||
| { | ||
| Action1 a = () => { |
Member
There was a problem hiding this comment.
Consider using a more obviously-bad name like "NonexistantDelegateType". Also consider adding tests for when the delegate type exists but is mismatched.
jaredpar
approved these changes
Jun 30, 2020
333fred
approved these changes
Jun 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #45398
Basically it seems like mostly we do give valid type info for a 'var' in a lambda, but we do not give nullability information when there is no valid conversion for the lambda. We may or may not wish to fix this, but it seemed worthwhile to demonstrate the current behavior in tests.