Revert "Move SymbolSearch down to EditorFeatures (#45505)"#45529
Merged
1 commit merged intodotnet:masterfrom Jun 29, 2020
Merged
Conversation
This reverts commit f755e8a. That change meant our EditorFeatures code was using DllImports in the cross-platform binary, and we weren't sure what that would do in VS for Mac if that code ran. It also brought a dependency on Microsoft.VisualStudio.RemoteControl, which also seems to depend on various Windows specific APIs. We'll finish up the decision of what to do in dotnet#45115
CyrusNajmabadi
approved these changes
Jun 29, 2020
tmat
approved these changes
Jun 29, 2020
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit f755e8a. That change meant our EditorFeatures code was using DllImports in the cross-platform binary, and we weren't sure what that would do in VS for Mac if that code ran. It also brought a dependency on Microsoft.VisualStudio.RemoteControl, which also seems to depend on various Windows specific APIs.
We'll finish up the decision of what to do in #45115