Migrate publishing feeds to azure#45416
Merged
dibarbet merged 17 commits intodotnet:masterfrom Jun 30, 2020
Merged
Conversation
dibarbet
commented
Jun 24, 2020
|
|
||
| $VSSetupDir = Join-Path $ArtifactsDir "VSSetup\$configuration" | ||
| $PackagesDir = Join-Path $ArtifactsDir "packages\$configuration" | ||
| $PublishDataUrl = "https://raw.githubusercontent.com/dotnet/roslyn/master/eng/config/PublishData.json" |
Member
Author
There was a problem hiding this comment.
Need to change this to master before I merge.
jaredpar
reviewed
Jun 24, 2020
| "vssdk": "https://pkgs.dev.azure.com/azure-public/vside/_packaging/vssdk/nuget/v3/index.json", | ||
| "vs-impl": "https://pkgs.dev.azure.com/azure-public/vside/_packaging/vs-impl/nuget/v3/index.json" | ||
| }, | ||
| "packages": { |
Member
There was a problem hiding this comment.
Listing this as a global entry means that it can never differ between our branches. Hence at any point in the future if we decide to change where these packages are published we'll be stuck because all branches will be reading this master list.
Member
Author
There was a problem hiding this comment.
I see - which would be better then, specifying the per branch mapping as a global entry (as we do currently for the other publishing data) or just reading this map from a place local to the currently running build?
Member
There was a problem hiding this comment.
The mapping just needs to be flexible here. Essentially what happens in the future when we need to change master but not break our publishing for release/dev16.8.
Think there are a couple ways to do this:
- Just add this data into our existing branch specific entries below. That will work just fine but it does mean that our file is going to start getting big really fast.
- Could do some type of diffing system where this is the default and we put deviations in the branch specific entries. Thta may be overkill though.
Member
Author
There was a problem hiding this comment.
I ended up with something in between 1 and 2:
- Added keys in the packages map that can define different sets of package mappings.
- Updated the branch configuration to reference the correct key from the packages object.
This way it's possible to change the mappings based on branch and re-use mappings when they don't change. Drawback is that the entire mapping has to be specified again, rather than just the diff. Seems simple enough for now and if we end up needing to modify it a lot we can re-think this.
Member
Author
jaredpar
reviewed
Jun 24, 2020
| "vssdk": "https://pkgs.dev.azure.com/azure-public/vside/_packaging/vssdk/nuget/v3/index.json", | ||
| "vs-impl": "https://pkgs.dev.azure.com/azure-public/vside/_packaging/vs-impl/nuget/v3/index.json" | ||
| }, | ||
| "packages": { |
Member
There was a problem hiding this comment.
The mapping just needs to be flexible here. Essentially what happens in the future when we need to change master but not break our publishing for release/dev16.8.
Think there are a couple ways to do this:
- Just add this data into our existing branch specific entries below. That will work just fine but it does mean that our file is going to start getting big really fast.
- Could do some type of diffing system where this is the default and we put deviations in the branch specific entries. Thta may be overkill though.
Member
I do not know. In general though I think for the |
Member
Author
|
Think this is mostly ready -
|
dibarbet
commented
Jun 24, 2020
| }, | ||
| "packages": { | ||
| "default": { | ||
| "Microsoft.CodeAnalysis" : "arcade", |
Member
Author
There was a problem hiding this comment.
I wanted the script to throw if it found any packages that did not have a properly configured feed, so I kept these mapped to arcade to show that these are intentionally not being uploaded.
tmat
reviewed
Jun 26, 2020
tmat
approved these changes
Jun 26, 2020
Member
Author
|
I'm going to hold off on merging this until after the snap Monday. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves - #39279
TODO -
Change to master publish data
Get API key for azure feeds and modify pipeline yaml