Skip to content

Do not permit default literals in relational patterns#45375

Merged
gafter merged 2 commits intodotnet:masterfrom
gafter:master-45292
Jun 23, 2020
Merged

Do not permit default literals in relational patterns#45375
gafter merged 2 commits intodotnet:masterfrom
gafter:master-45292

Conversation

@gafter
Copy link
Member

@gafter gafter commented Jun 23, 2020

Fixes #45292

@gafter gafter added this to the Compiler.Net5 milestone Jun 23, 2020
@gafter gafter requested a review from a team as a code owner June 23, 2020 02:12
@gafter gafter self-assigned this Jun 23, 2020
@jcouv jcouv self-assigned this Jun 23, 2020
@gafter
Copy link
Member Author

gafter commented Jun 23, 2020

@jcouv I think I've addressed your comment. Do you have any others?

Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 2)

@gafter gafter merged commit 430056a into dotnet:master Jun 23, 2020
@ghost ghost modified the milestones: Compiler.Net5, Next Jun 23, 2020
@dibarbet dibarbet modified the milestones: Next, 16.7.P4 Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should not permit default literals in relational patterns

4 participants