Merged
Conversation
jaredpar
approved these changes
Jun 22, 2020
d55e23d to
9204964
Compare
Member
Author
|
@dotnet/roslyn-compiler for review please :) |
9204964 to
24c11a2
Compare
RikkiGibson
approved these changes
Jun 23, 2020
333fred
reviewed
Jun 23, 2020
333fred
approved these changes
Jun 23, 2020
This was referenced Jun 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two global analyzer issues:
Commit1: When we renamed the targets files, we also accidentally renamed the
AnalyzerConfigFilesitem toEditorConfigFilesmeaning it was no longer passed to the compiler. We didn't have tests for this before, but we've since added target tests and I've added a test to cover this specific case.Commit2: Global analyzer config options where getting incorrectly cleared when there was a root config lower in the hierarchy. This is a somewhat niche case but we are hitting it in the source generator samples in roslyn-sdk. Fixed and added a test to verify a combination of root config cases.