Make VisitType tail recursive in more cases#45328
Merged
333fred merged 2 commits intodotnet:masterfrom Jun 23, 2020
Merged
Conversation
AlekseyTs
reviewed
Jun 22, 2020
Contributor
|
Done with review pass (iteration 1) |
Member
Author
|
@AlekseyTs addressed feedback. |
jaredpar
approved these changes
Jun 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when we encounter a INamedTypeSymbol or a function pointer in
VisitType, we abandon any attempt to be tail recursive and instead go for a fully recursive solution. This makes the code simple, but it does mean that we are recursive even for the simple case of a named type with one type argument, which is completely possible to handle without any recursion whatsoever. This changes our implementation to always be tail recursive for the last type argument or function pointer type.