Show format string completion options when the initial quote is typed#45309
Merged
CyrusNajmabadi merged 3 commits intodotnet:masterfrom Jun 22, 2020
Merged
Conversation
| ]]></Document>, showCompletionInArgumentLists:=showCompletionInArgumentLists) | ||
|
|
||
| state.SendTypeChars("""") | ||
| Await state.AssertNoCompletionSession() |
Contributor
There was a problem hiding this comment.
awesome. i was hoping you'd have this tes t:)
src/EditorFeatures/Test2/IntelliSense/CSharpCompletionCommandHandlerTests_DateAndTime.vb
Show resolved
Hide resolved
| context.AddStandard("F", FeaturesResources.full_long_date_time, FeaturesResources.full_long_date_time_description); | ||
| context.AddStandard("g", FeaturesResources.general_short_date_time, FeaturesResources.general_short_date_time_description); | ||
| context.AddStandard("G", FeaturesResources.general_long_date_time, FeaturesResources.general_long_date_time_description); | ||
| context.AddStandard("G", FeaturesResources.general_long_date_time, FeaturesResources.general_long_date_time_description, isDefault: true); // This is what DateTime.ToString() uses |
Contributor
There was a problem hiding this comment.
ok. let's try this out for now :)
CyrusNajmabadi
approved these changes
Jun 19, 2020
Contributor
Author
|
Why is this PR in the Completed column of https://github.com/dotnet/roslyn/projects/36 if it has not merged? |
Contributor
|
@jnm2 that was a mistake, have corrected it. thanks for catching |
Contributor
|
Awesome thanks! |
Contributor
Author
|
🎉 Thank you Jinu! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reminds me that the feature exists and that I don't need to search my way over to the docs to remember what I want.
fyi @CyrusNajmabadi