Skip to content

Revert "Remove IActiveStatementSpanTracker from the MEF catalog"#45239

Merged
chsienki merged 1 commit intodotnet:masterfrom
chsienki:revert_workspace_factory
Jun 17, 2020
Merged

Revert "Remove IActiveStatementSpanTracker from the MEF catalog"#45239
chsienki merged 1 commit intodotnet:masterfrom
chsienki:revert_workspace_factory

Conversation

@chsienki
Copy link
Member

@chsienki chsienki commented Jun 16, 2020

This reverts commit 31a883f.

@CyrusNajmabadi
Copy link
Contributor

CyrusNajmabadi commented Jun 16, 2020

Why reverting?

@chsienki
Copy link
Member Author

chsienki commented Jun 16, 2020

We're seeing issues with tests in RPS. Theory is this PR, but we're testing.

@chsienki chsienki marked this pull request as ready for review June 17, 2020 18:23
@chsienki chsienki requested a review from a team as a code owner June 17, 2020 18:23
dibarbet
dibarbet approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@dibarbet dibarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this PR is the one causing RPS issues
Passed successfully with this revert - https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/255302

@dibarbet
Copy link
Member

dibarbet commented Jun 17, 2020 •
edited by jinujoseph
Loading

FYI @sharwell , @tmat

@chsienki chsienki merged commit d04ebc2 into dotnet:master Jun 17, 2020
@ghost ghost added this to the Next milestone Jun 17, 2020
@sharwell
Copy link
Contributor

sharwell commented Jun 21, 2020

@chsienki Where can I find the context for this? This PR was a prerequisite for my work this coming week.

@chsienki
Copy link
Member Author

chsienki commented Jun 22, 2020

@sharwell We were seeing errors in EnC when running RPS tests. The specific failure was

06/14/2020 00:55:03 Coordinated Universal Time: Error : 1 :[devenv:3020] Unexpected exception: System.InvalidOperationException: Service of type 'Microsoft.CodeAnalysis.EditAndContinue.IActiveStatementSpanTrackerFactory' is required to accomplish the task but is not available from the workspace.
   at Microsoft.CodeAnalysis.Host.HostWorkspaceServices.GetRequiredService[TWorkspaceService]()
   at Microsoft.CodeAnalysis.CSharp.EditAndContinue.CSharpEditAndContinueAnalyzer.Factory.CreateLanguageService(HostLanguageServices languageServices)
   at Microsoft.CodeAnalysis.Host.Mef.MefLanguageServices.<>c__DisplayClass4_1.<.ctor>b__2()
   at System.Lazy`1.CreateValue()
   at System.Lazy`1.LazyInitValue()
   at System.Lazy`1.get_Value()
   at Microsoft.CodeAnalysis.Host.Mef.MefLanguageServices.GetService[TLanguageService]()
   at Microsoft.CodeAnalysis.EditAndContinue.EditAndContinueWorkspaceService.SupportsEditAndContinue(Project project)
   at Microsoft.CodeAnalysis.EditAndContinue.EditSession.<CreateActiveStatementsMap>g__supportsEditAndContinue|21_0(DocumentId documentId)
   at System.Linq.ImmutableArrayExtensions.FirstOrDefault[T](ImmutableArray`1 immutableArray, Func`2 predicate)
   at Microsoft.CodeAnalysis.EditAndContinue.EditSession.CreateActiveStatementsMap(ImmutableArray`1 debugInfos)
   at Microsoft.CodeAnalysis.EditAndContinue.EditSession.<GetBaseActiveStatementsAsync>d__20.MoveNext()

@chsienki chsienki deleted the revert_workspace_factory branch June 22, 2020 17:01
@dibarbet dibarbet modified the milestones: Next, 16.7.P4 Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dibarbet dibarbet dibarbet approved these changes

+1 more reviewer

@vatsalyaagrawal vatsalyaagrawal vatsalyaagrawal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

16.7.P4

Development

Successfully merging this pull request may close these issues.

5 participants

@chsienki @CyrusNajmabadi @dibarbet @sharwell @vatsalyaagrawal