Support FieldDeclarationSyntax in CS8618 fixer#45227
Support FieldDeclarationSyntax in CS8618 fixer#45227jasonmalinowski merged 9 commits intodotnet:masterfrom
Conversation
src/EditorFeatures/CSharpTest/Diagnostics/Nullable/CSharpDeclareAsNullableCodeFixTests.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
LGTM with attribute added.
|
@CyrusNajmabadi The test is failing. I'll try to debug soon. I'll add the WorkItem attribute when fixing the current failure. |
|
@Youssef1313 Not sure why the test is failing either; the code looks right. Ping me when you fix it up and I'll take a look again. |
|
@jasonmalinowski The test should be passing now. |
|
There is a build failure, but in some other test I don't know about. |
src/Features/CSharp/Portable/CodeFixes/Nullable/CSharpDeclareAsNullableCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
|
@Youssef1313 Looks like that's a random failure with the integration test; I think we need one more fix here, and that failing job will rerun when we push a change. |
src/EditorFeatures/CSharpTest/Diagnostics/Nullable/CSharpDeclareAsNullableCodeFixTests.cs
Show resolved
Hide resolved
src/EditorFeatures/CSharpTest/Diagnostics/Nullable/CSharpDeclareAsNullableCodeFixTests.cs
Outdated
Show resolved
Hide resolved
…reAsNullableCodeFixTests.cs
|
LMK when this passes, and i'll merge in. |
|
Not sure what is the reason of the test failure. @CyrusNajmabadi, Can you take a look please? |
|
This test is failing:
I'll make the suggestion in the PR code, one sec. |
src/EditorFeatures/CSharpTest/Diagnostics/Nullable/CSharpDeclareAsNullableCodeFixTests.cs
Outdated
Show resolved
Hide resolved
…reAsNullableCodeFixTests.cs Co-authored-by: Jason Malinowski <jason@jason-m.com>
jasonmalinowski
left a comment
There was a problem hiding this comment.
Code looks good, just needs the test to be fixed up and this is ready to go in.
|
@jasonmalinowski Is the following message is the reason for the failure or there is something wrong with the PR itself? |
|
@Youssef1313 I've reset the PR; at this point I think that's some flakiness in our infrastructure and this is good to go otherwise. |
|
Thanks @Youssef1313 for the fix! |

Fixes #44983