Report better errors when multiple invalid constraints are combined#45147
Report better errors when multiple invalid constraints are combined#45147333fred merged 4 commits intodotnet:masterfrom
Conversation
Instead of reporting that a constraint must come first, if there are multiple constraints that must come first, we now report that these constraints cannot be combined. We also suppress these errors if a previous error about inherited constraints was reported. Fixes dotnet#45141.
does it mean that |
@xparadoxical sorry, I copied the wrong URL in the description. This PR is unrelated to that bug. |
|
@dotnet/roslyn-compiler for reviews on this small diagnostic message cleanup |
RikkiGibson
left a comment
There was a problem hiding this comment.
LGTM, just surprised that we didn't have a localizable way of referring to the 'class' and 'struct' language concepts until now.
|
Done with review pass (iteration 2), tests are not looked at #Closed |
|
@AlekseyTs addressed feedback. In reply to: 645028784 [](ancestors = 645028784) |
|
@333fred It looks like there are legitimate test failures. #Closed |
|
Done with review pass (iteration 3) #Closed |
|
@AlekseyTs addressed feedback. In reply to: 645772487 [](ancestors = 645772487) |
Instead of reporting that a constraint must come first, if there are multiple constraints that must come first, we now report that these constraints cannot be combined. We also suppress these errors if a previous error about inherited constraints was reported. Fixes #45141.