#3438, use standard Type Conversion Functions when possible#45139
Merged
mavasani merged 6 commits intodotnet:masterfrom Jul 13, 2020
Merged
#3438, use standard Type Conversion Functions when possible#45139mavasani merged 6 commits intodotnet:masterfrom
mavasani merged 6 commits intodotnet:masterfrom
Conversation
Contributor
Author
|
@jinujoseph what does BuddyAssigned mean? |
Contributor
|
@jrmoreno1 it means you have a buddy @mavasani who will help you with questions/review/connecting to right people while you help us with this fix. |
Contributor
Author
|
@mavasani, all of the failed tests are integration and system failures as far as I can tell. I can’t find a way to rerun the test without making a change in order to be sure, and I don’t want to do that. |
mavasani
approved these changes
Jul 13, 2020
Contributor
|
@jrmoreno1 I have restarted the failed runs for you, seems like these were unrelated intermittent test failures. |
jmarolf
approved these changes
Jul 13, 2020
Contributor
|
Thanks for the contribution @jrmoreno1! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use standard Type Conversion Functions when possible (including CStr), and not CType.