Compute and check document indices in parallel#45073
Merged
6 commits merged intodotnet:masterfrom Jun 11, 2020
Merged
Conversation
This reverts commit 3ff438e.
dibarbet
reviewed
Jun 11, 2020
Member
dibarbet
left a comment
There was a problem hiding this comment.
just want to understand the duplicates question, then happy to sign off
...orkspaces/Core/Portable/FindSymbols/FindReferences/FindReferencesSearchEngine_MapCreation.cs
Outdated
Show resolved
Hide resolved
...orkspaces/Core/Portable/FindSymbols/FindReferences/FindReferencesSearchEngine_MapCreation.cs
Outdated
Show resolved
Hide resolved
dibarbet
approved these changes
Jun 11, 2020
sharwell
reviewed
Jun 11, 2020
| using (Logger.LogBlock(FunctionId.FindReference_CreateDocumentMapAsync, _cancellationToken)) | ||
| { | ||
| var finalMap = new ProjectToDocumentMap(); | ||
| using var _ = ArrayBuilder<Task<(ImmutableArray<Document>, ISymbol, IReferenceFinder)>>.GetInstance(out var tasks); |
Contributor
There was a problem hiding this comment.
💡 In this case, we know the exact number of tasks. We should create the required array directly.
Contributor
Author
There was a problem hiding this comment.
that's reasonable. i can make that cahnge in one of my other FAR PRs that build off of this. :)
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cuts down the time it takes for my computer to perform this portion of FAR (on workstation GC) by a solid 40%.