Skip to content

Implement SemanticModel.GetConversion for switch expressions.#45069

Merged
gafter merged 4 commits intodotnet:masterfrom
gafter:master-45041
Jun 16, 2020
Merged

Implement SemanticModel.GetConversion for switch expressions.#45069
gafter merged 4 commits intodotnet:masterfrom
gafter:master-45041

Conversation

@gafter
Copy link
Member

@gafter gafter commented Jun 11, 2020

Fixes #45041

@gafter gafter requested a review from a team as a code owner June 11, 2020 01:30
@gafter gafter self-assigned this Jun 11, 2020
@gafter gafter added this to the 16.7 milestone Jun 11, 2020
@gafter
Copy link
Member Author

gafter commented Jun 11, 2020 •
edited
Loading

/cc @allisonchou #Closed

cston
cston reviewed Jun 11, 2020
View reviewed changes
@AlekseyTs
Copy link
Contributor

AlekseyTs commented Jun 11, 2020 •
edited by gafter
Loading

Done with review pass (iteration 1) #Resolved

@gafter
Copy link
Member Author

gafter commented Jun 12, 2020 •
edited
Loading

@AlekseyTs I believe I have responded to all of your comments. Do you have any others? #Resolved

@gafter
Copy link
Member Author

gafter commented Jun 15, 2020

@dotnet/roslyn-compiler May I please have a second review?

@AlekseyTs
Copy link
Contributor

AlekseyTs commented Jun 15, 2020 •
edited by gafter
Loading

Done with review pass (iteration 2) #Resolved

@gafter
Copy link
Member Author

gafter commented Jun 15, 2020

@AlekseyTs I believe I have responded to all of your comments. Do you have any others?

@gafter
Copy link
Member Author

gafter commented Jun 15, 2020

@AlekseyTs I believe that answers your question. Do you have any others?

AlekseyTs
AlekseyTs approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing-off (iteration 4)

@gafter gafter merged commit 88dd4bb into dotnet:master Jun 16, 2020
@ghost ghost removed this from the 16.7 milestone Jun 16, 2020
@ghost ghost added this to the Next milestone Jun 16, 2020
@allisonchou allisonchou mentioned this pull request Jun 23, 2020
Merged
@dibarbet dibarbet modified the milestones: Next, 16.7.P4 Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlekseyTs AlekseyTs AlekseyTs approved these changes

+1 more reviewer

@cston cston cston approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gafter gafter

Labels

Area-Compilers Feature - Pattern Matching Pattern Matching

Projects

None yet

Milestone

16.7.P4

Development

Successfully merging this pull request may close these issues.

Semantic model incorrectly gives type for switch expression

4 participants

@gafter @AlekseyTs @cston @dibarbet