Merged
Conversation
Member
Author
|
@jasonmalinowski For VSIX authoring. |
26193c6 to
23c1635
Compare
Member
|
I'm wondering if the change in optprof config would cause any issue during build: we would miss ibc data for moved assemblies |
86d3197 to
8cbe849
Compare
Member
Author
|
@dotnet/roslyn-ide |
jmarolf
reviewed
Jun 29, 2020
jmarolf
reviewed
Jun 29, 2020
src/Compilers/Shared/GlobalAssemblyCacheHelpers/GacFileResolver.cs
Outdated
Show resolved
Hide resolved
jmarolf
reviewed
Jun 29, 2020
src/EditorFeatures/Core.Wpf/Interactive/CSharpVBResetCommand.cs
Outdated
Show resolved
Hide resolved
Contributor
|
I would do a test insertion of this. |
b9655a9 to
6002797
Compare
Member
jasonmalinowski
left a comment
There was a problem hiding this comment.
Comments so far; my only real conclusion is I'm not qualified to review this. 😄
src/EditorFeatures/Core.Wpf/Interactive/InteractiveEvaluatorResetOptions.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/Core.Wpf/Interactive/CSharpVBResetCommand.cs
Outdated
Show resolved
Hide resolved
...s/Core/Implementation/Interactive/Completion/AbstractReferenceDirectiveCompletionProvider.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/Core.Wpf/Interactive/InteractiveEvaluator.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/Core.Wpf/Interactive/InteractiveEvaluator.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/Core.Wpf/Interactive/InteractiveEvaluator.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/Core.Wpf/Interactive/InteractiveEvaluator.cs
Outdated
Show resolved
Hide resolved
b1f7484 to
fb80619
Compare
fb80619 to
6e39316
Compare
Simplify keeping search paths in-sync between InteractiveHost and InteractiveEvaluator.
6e39316 to
efc47e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates Roslyn Setup VSIX to include InteractiveHost for both Desktop and Core CLR.
Removes InteractiveComponents VSIX and uses publishing target in InteractiveHost.csproj instead to gather all files necessary to run InteractiveHost process.
Retargets Microsoft.CodeAnalysis.InteractiveHost to netstandard2.0 and moves Windows and .NET Framework specific logic to
InteractiveHost.exe.Adds a new option to
#resetcommand that allows the user to switch Interactive Window host to .NET Core:#reset 32- switches to .NET Framework 32-bit process#reset 64- switches to .NET Framework 64-bit process#reset core- switches to .NET Core 64-bit processLeaves the default to .NET Framework 64-bit for now.
Fixes #4788
Fixes #5538