Only include compilation options in the PDB that don't have default value#45044
Merged
tmat merged 3 commits intodotnet:masterfrom Jun 18, 2020
Merged
Only include compilation options in the PDB that don't have default value#45044tmat merged 3 commits intodotnet:masterfrom
tmat merged 3 commits intodotnet:masterfrom
Conversation
Member
Author
chsienki
reviewed
Jun 10, 2020
src/Test/Utilities/Portable/PDB/DeterministicBuildCompilationTestHelpers.cs
Outdated
Show resolved
Hide resolved
ryzngard
reviewed
Jun 10, 2020
src/Test/Utilities/Portable/PDB/DeterministicBuildCompilationTestHelpers.cs
Outdated
Show resolved
Hide resolved
ryzngard
suggested changes
Jun 10, 2020
Contributor
ryzngard
left a comment
There was a problem hiding this comment.
Please check value is missing
chsienki
reviewed
Jun 10, 2020
src/Compilers/Core/Portable/PEWriter/MetadataWriter.PortablePdb.cs
Outdated
Show resolved
Hide resolved
Member
Author
ryzngard
reviewed
Jun 15, 2020
ryzngard
approved these changes
Jun 15, 2020
jaredpar
approved these changes
Jun 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
portability-policyemitted to PDB CompilationOptions record is only relevant for legacy Silverlight builds. It's always0otherwise. No reason to include it if it has the default value.