Apply #44854 to preview3 branch#45011
Merged
RikkiGibson merged 3 commits intodotnet:release/dev16.7-preview3from Jun 10, 2020
Merged
Apply #44854 to preview3 branch#45011RikkiGibson merged 3 commits intodotnet:release/dev16.7-preview3from
RikkiGibson merged 3 commits intodotnet:release/dev16.7-preview3from
Conversation
cston
approved these changes
Jun 10, 2020
Member
Author
|
Implementation changes have been merged, the new changes in this PR are test-only therefore will just merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44863
We like this change so much that we want to take it into preview3. Thanks again @nbalakin! 😄
My git skills started failing me a bit here, so I ended up just checking out the 'master' version of all the files changes in #44854. It appears to produce the same diff as in that PR, and it also merges cleanly into 'master', so I think we're good..?