Fix parsing of nested verbatim interpolated strings started with @$#44924
Merged
jcouv merged 2 commits intodotnet:masterfrom Jul 6, 2020
Merged
Fix parsing of nested verbatim interpolated strings started with @$#44924jcouv merged 2 commits intodotnet:masterfrom
jcouv merged 2 commits intodotnet:masterfrom
Conversation
|
|
jcouv
reviewed
Jun 23, 2020
jcouv
reviewed
Jun 23, 2020
Member
jcouv
left a comment
There was a problem hiding this comment.
Done with review pass (iteration 1)
…r unit tests and test the error.
Contributor
Author
|
Added the language version diagnostic and unit test for it. This test style seems superior so I've deleted the old test. Note that the error location is the |
Member
|
@dotnet/roslyn-compiler for a second review of community PR. Thanks |
Member
|
Merged/squashed. Thanks @rstarkov for the contribution! :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parsing an interpolated string, the function that scans to find the end of an interpolated hole,
ScanInterpolatedStringLiteralHoleBalancedText, does not correctly account for the possibility of a nested string starting with @$.This PR fixes this by copying the code already present for the $@ case just a few
cases earlier.I've included a unit test which fails without this patch.