Put record parameters in scope withing instance initializers#44906
Merged
jcouv merged 5 commits intodotnet:features/recordsfrom Jun 6, 2020
Merged
Put record parameters in scope withing instance initializers#44906jcouv merged 5 commits intodotnet:features/recordsfrom
jcouv merged 5 commits intodotnet:features/recordsfrom
Conversation
jaredpar
approved these changes
Jun 6, 2020
Contributor
Author
|
@agocke, @RikkiGibson, @cston, @jcouv, @dotnet/roslyn-compiler Please review, need a second sign-off, the amount of changes is small. |
cston
reviewed
Jun 6, 2020
| ); | ||
|
|
||
| TestLookupNames(text, expectedNames); | ||
| } |
Contributor
There was a problem hiding this comment.
Consider testing a const field as well. #Resolved
Contributor
Author
There was a problem hiding this comment.
Consider testing a const field as well.
Const fields are static fields, so I am pretty confident this test is fairly equivalent to verify scoping rules. I will add a test like that for completeness sake in a separate PR
In reply to: 436281327 [](ancestors = 436281327)
cston
reviewed
Jun 6, 2020
| Assert.Equal("System.Int32 C.Z", model.GetEnclosingSymbol(x.SpanStart).ToTestDisplayString()); | ||
| Assert.Contains(symbol, model.LookupSymbols(x.SpanStart, name: "X")); | ||
| Assert.Contains("X", model.LookupNames(x.SpanStart)); | ||
| } |
Contributor
There was a problem hiding this comment.
Consider testing capturing:
record C(int X)
{
Func<int> F = () => X;
}
``` #Resolved
cston
approved these changes
Jun 6, 2020
Member
|
FYI, resolved conflicts following Chuck's PR. |
Member
|
@jcouv there are analyzer diagnostics in the Correctness run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/dotnet/csharplang/blob/master/meetings/2020/LDM-2020-06-01.md
Also fixes #44879.