Remove GetPositionBeforeParameterListClosingBrace from Change Signature#44799
Merged
dpoeschl merged 2 commits intodotnet:masterfrom Jun 9, 2020
Merged
Conversation
Contributor
|
:'( |
Contributor
Author
I know. I probably should have built locally before submitting a PR that doesn't build... 😬 |
13b60a2 to
46d0d1f
Compare
Contributor
Author
|
Tagging @dotnet/roslyn-ide @allisonchou @CyrusNajmabadi for review |
allisonchou
approved these changes
Jun 8, 2020
Contributor
Author
|
@jinujoseph Is this okay to merge to |
Contributor
|
@dpoeschl yes feel free to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method was leftover from when we tried to have the completion list in the Add Parameter dialog, and also was buggy. Since we currently do not attempt completion there and instead check for type binding, we just need a position where types will bind as desired.
Fixes #44603