Ensure that we show all applicable refactorings for lightbulb under t…#44796
Ensure that we show all applicable refactorings for lightbulb under t…#44796mavasani merged 1 commit intodotnet:masterfrom
Conversation
|
|
||
| var filteredRefactorings = FilterOnUIThread(refactorings, workspace); | ||
| // If we are computing refactorings outside the 'Refactoring' context, i.e. for example, from the lightbulb under a squiggle or selection, | ||
| // then we want to filter out refactorings outside the selection span. |
There was a problem hiding this comment.
i would explain 'why' (or link to an issue).
| return (new RenameTrackingCodeAction( | ||
| document, title, refactorNotifyServices, undoHistoryRegistry), | ||
| snapshotSpan.Span.ToTextSpan()); |
There was a problem hiding this comment.
| return (new RenameTrackingCodeAction( | |
| document, title, refactorNotifyServices, undoHistoryRegistry), | |
| snapshotSpan.Span.ToTextSpan()); | |
| return (new RenameTrackingCodeAction(document, title, refactorNotifyServices, undoHistoryRegistry), | |
| snapshotSpan.Span.ToTextSpan()); |
|
Would really like an integration test here. |
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
can we please do an integratin test here?
I could not find an easy way to add an integration test here. Need to investigate how to invoke that lightbulb. I have filed #44855 to track this work, I'll prioritize it for today. However, I don't want to let this PR hang around longer and risk this regression shipping in 16.7, so I am going to merge this PR. Hope that is fine. |
Please do prioritize though. It is important we don't regress this. I assume you did manually validate though? |
Yes, I did!
Yep, investigating now. |
…he caret
Fixes #44594
Verified that rename tracking code action now shows up in the lightbulb under the caret