Remove old classifications experiment#44775
Merged
dibarbet merged 4 commits intodotnet:masterfrom Jun 3, 2020
Merged
Conversation
src/VisualStudio/LiveShare/Impl/Client/Classification/RoslynSyntaxClassificationService.cs
Show resolved
Hide resolved
src/VisualStudio/LiveShare/Impl/Client/Classification/RoslynSyntaxClassificationService.cs
Show resolved
Hide resolved
941cbcf to
0e343bb
Compare
jasonmalinowski
approved these changes
Jun 3, 2020
Member
jasonmalinowski
left a comment
There was a problem hiding this comment.
You missed one more line to delete, but looks good.
...isualStudio/LiveShare/Impl/Client/Classification/RoslynSyntaxClassificationServiceFactory.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete experimental code that ended up never being used. We'll use the classifications from the LSP spec (and LSP client tagger) if we need to do remote syntax classifications in the future.