Include the workspaces and code style layers in Compilers.slnf#44751
Merged
sharwell merged 1 commit intodotnet:masterfrom Jun 2, 2020
Merged
Include the workspaces and code style layers in Compilers.slnf#44751sharwell merged 1 commit intodotnet:masterfrom
sharwell merged 1 commit intodotnet:masterfrom
Conversation
CyrusNajmabadi
approved these changes
Jun 1, 2020
Member
|
@sharwell Thanks for the fast response to fix that issue. However, I just made these exact same changes locally, and I still cannot find the file. (I tried closing Visual Studio and re-opening it, but nothing changed)
|
Contributor
Author
|
@Youssef1313 Did you open Compilers.sln or Compilers.slnf? This pull request only updates the latter. |
Member
|
@sharwell, I've opened the .sln as it's the one mentioned in the issue. |
Contributor
Author
|
The .sln file exists as a workaround for command line builds until dotnet/msbuild#4097 ships. The .slnf file should provide a better development experience. |
Member
|
Thanks. Confirmed that it works with the slnf. |
jaredpar
approved these changes
Jun 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compilers.sln already included the csproj/vbproj projects from these layers.
See #44723