Skip to content

Allow rename file even if rename was no initiated in that file#44577

Merged
6 commits merged intodotnet:masterfrom
ryzngard:issues/44576_rename_from_other_file
Jun 9, 2020
Merged

Allow rename file even if rename was no initiated in that file#44577
6 commits merged intodotnet:masterfrom
ryzngard:issues/44576_rename_from_other_file

Conversation

@ryzngard
Copy link
Contributor

Fixes #44576

@ryzngard ryzngard requested a review from a team as a code owner May 26, 2020 23:28
@ryzngard ryzngard requested a review from a team May 26, 2020 23:28
@ryzngard
Copy link
Contributor Author

Open Question:

This might be odd because the dialog says "Rename File" even though it is renaming a different file

image

@CyrusNajmabadi
Copy link
Contributor

This might be odd because the dialog says "Rename File" even though it is renaming a different file

maybe rename symbol's file?

@ryzngard ryzngard requested a review from a team May 27, 2020 20:13
Copy link
Contributor

@jmarolf jmarolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit 08a96e2 into dotnet:master Jun 9, 2020
@ryzngard ryzngard deleted the issues/44576_rename_from_other_file branch June 23, 2020 20:36
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reneme class and it's filename from a different file works only when current file has same name

3 participants