Skip to content

Restore 'generate constructor (without fields)'#44549

Merged
1 commit merged intodotnet:masterfrom
CyrusNajmabadi:genConstructor
May 26, 2020
Merged

Restore 'generate constructor (without fields)'#44549
1 commit merged intodotnet:masterfrom
CyrusNajmabadi:genConstructor

Conversation

@CyrusNajmabadi
Copy link
Contributor

Note: looks like a hole in the testing harness. We have tests for this feature, but it looks like it doesn't go through the normal codefixservice path that filters out actions with the same equivalence key.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner May 26, 2020 00:30
@CyrusNajmabadi CyrusNajmabadi requested a review from mavasani May 26, 2020 00:30
Copy link
Contributor

@mavasani mavasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be good to file a tracking issue for the test hole.

@CyrusNajmabadi
Copy link
Contributor Author

Will be good to file a tracking issue for the test hole.

Will do.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit 2f6273b into dotnet:master May 26, 2020
@jinujoseph jinujoseph added this to the 16.7.P3 milestone May 26, 2020
@CyrusNajmabadi CyrusNajmabadi deleted the genConstructor branch June 11, 2020 18:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants