Skip post-build stages for validation build#44298
Merged
2 commits merged intodotnet:masterfrom May 16, 2020
Merged
Conversation
genlu
commented
May 15, 2020
| # since we don't want to publish validation build. | ||
| validateDependsOn: | ||
| - SetValidateDependency | ||
| dependsOn: |
Member
Author
There was a problem hiding this comment.
We set both because arcade 1.0 uses dependsOn and arcade 5.0 uses validateDependsOn, and I'm not certain why we are switching back and force.
Member
Author
There was a problem hiding this comment.
Also I found it's odd that AzDo doesn't complain about assigning value to an non-existing template parameter. Not sure if there's a reason behind that or just simply an oversight. @tmat Whom could I talk to about this?
JoeRobich
approved these changes
May 15, 2020
Member
JoeRobich
left a comment
There was a problem hiding this comment.
Be sure to link to your PR validation run. =)
genlu
commented
May 16, 2020
Member
Author
genlu
left a comment
There was a problem hiding this comment.
Here's the test validation build. Worked as expected.
https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/results?buildId=3733516&view=results
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.